Skip to content

Autocomplete: Simplify _create() method #1490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Autocomplete: Simplify _create() method #1490

wants to merge 1 commit into from

Conversation

jzaefferer
Copy link
Member

Uses logical expressions in place of conditional expressions.

Thanks for @rxaviers for noticing this in the first place.

@jzaefferer
Autocomplete: Simplify _create() method
0831835 
Uses logical expressions in place of conditional expressions.
@jzaefferer jzaefferer mentioned this pull request Mar 13, 2015
Merged
@jzaefferer jzaefferer added this to the land-before-esformatter milestone Mar 13, 2015
@scottgonzalez
Copy link
Member

I personally find this logic harder to follow, but I won't object to the change.

@arschmitz
Copy link
Member

I prefer the the new logic. To me it is easier to follow.

@jzaefferer jzaefferer deleted the autocomplete-create-simplification branch March 17, 2015 15:06
scottgonzalez pushed a commit that referenced this pull request Jun 9, 2016
@jzaefferer @scottgonzalez
Autocomplete: Simplify _create() method
ec44c24 
Uses logical expressions in place of conditional expressions.

Closes #1490

(cherry picked from commit 4212d07)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jzaefferer @scottgonzalez @arschmitz @jquerybot